test: widen process exit wait timeout to survive loaded ci#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kill_terminates_running_processfailed on ubuntu CI with "process did not exit in time". The kill path is reliable, but under a loaded CI runner the async chain (group kill -> child.wait() wakes -> mark_exited -> list reflects Exited) can take longer than the 2s test timeout, making it flaky rather than a real bug. Widenwait_until_exitedfrom 2s to 10s. A genuine kill failure still fails within 10s, so bug-detection is preserved.Reproduced the environment in a Linux (rust:1.95) container under CPU-saturated load; the widened timeout passes 15/15.
Verification
cargo test -p goat-agent --lib process::— passed (10 tests), incl. under--cpus=2+ busy-loop load in a Linux container (15/15)cargo clippy -p goat-agent --all-targets -- -D warnings— passedcargo fmt --all --check— passed